In one of my projects I wrote a small tournament platform, but the way I handle the participants is a bit messy and I want to clean this up.
So in my case, a Tournament can have participants, but a User or a Team can register to become participants. A participant now has a user_id or team_id in the database, and depending on which one is full, I determine if a user is linked to the participant or if it is a team.
I rewrote the registration part of my Tournament model to accept a User or a Team as parameter through the am interface and I was wondering if this is the correct way to do it.
ICandidate.php
interface ICandidate
{
public function getName();
public function hasCorrectGamesSet($tournamentGame);
}
User.php
class User implements ICandidate
{
private $game;
public function __construct($game)
{
$this->game = $game;
}
public function getName()
{
return 'Username';
}
public function hasCorrectGamesSet($tournamentGame)
{
if($this->game != $tournamentGame){
throw new Exception('Incorrect name');
};
return true;
}
}
Team.php
class Team implements ICandidate
{
private $users;
public function __construct($users)
{
$this->users = $users;
}
public function getName()
{
return 'Teamname';
}
public function hasCorrectGamesSet($tournamentGame)
{
foreach($this->users as $user){
$user->hasCorrectGamesSet($tournamentGame);
}
}
}
Participant.php
class Participant
{
private $name;
private $class;
public function setName($name)
{
$this->name = $name;
}
public function setClass($class)
{
$this->class = $class;
}
}
Tournament.php
class Tournament
{
private $participants;
private $game;
public function __construct($game)
{
$this->game = $game;
}
public function signUp(ICandidate $candidate)
{
$candidate->hasCorrectGamesSet($this->game);
$participant = new Participant();
$participant->setName($candidate->getName());
$participant->setClass(get_class($candidate));
$this->participants() = $participant;
}
public function getParticipants()
{
var_dump($this->participants);
}
}
So with this set, I can register a User or a Team, do a little checking and, if that happens, add them as tournament participants.
Logic
$tournament = new Tournament('fifa');
$user1 = new User('fifa');
$user2 = new User('fifa');
$user3 = new User('fifa');
$user4 = new User('fifa');
$team = new Team(($user2, $user3, $user4));
$tournament->signUp($user1);
$tournament->signUp($team);
$tournament->getParticipants();
Is this a correct way to implement this and make use of the interface?
